Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the instance tests #1151

Merged
merged 12 commits into from
Aug 29, 2024
Merged

Conversation

jalextowle
Copy link
Contributor

Description

This PR refactors the instance tests to reduce the amount of changes that must be made for each new instance. This also paves the way for future changes to improve the integration developer experience.

@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2024

Pull Request Test Coverage Report for Build 10621124841

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.961%

Totals Coverage Status
Change from base Build 10605194935: 0.0%
Covered Lines: 2312
Relevant Lines: 2570

💛 - Coveralls

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!!

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see this... awesome work!

image

test/instances/aave/AaveHyperdrive.t.sol Show resolved Hide resolved
@jalextowle jalextowle added this pull request to the merge queue Aug 29, 2024
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: 75a3e07 Previous: 548e6a2 Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 193160 gas 192525 gas 0.3298% 🚨
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147708 gas 147735 gas -0.0183%
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 129895 gas 129759 gas 0.1048% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124746 gas 124878 gas -0.1057%
closeShort: max 277300 gas 277300 gas 0% 🟰
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355945 gas 355840 gas 0.0295% 🚨
initialize: max 424766 gas 424766 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173730 gas 173740 gas -0.0058%
openLong: max 339743 gas 339743 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172636 gas 172325 gas 0.1805% 🚨
openShort: max 415078 gas 412464 gas 0.6338% 🚨
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74825 gas 74876 gas -0.0681%
redeemWithdrawalShares: max 311190 gas 311190 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 216303 gas 216232 gas 0.0328% 🚨
removeLiquidity: max 403683 gas 403671 gas 0.0030% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Merged via the queue into main with commit bad6abb Aug 29, 2024
31 checks passed
@jalextowle jalextowle deleted the jalextowle/refactor/improve-instance-tests branch August 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants