update calc_open_short to match solidity

[dpaiton]

Resolved Issues

Description

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.

[[Reviewer Name]]

Rust

• Testing
  • Are there new or updated unit or integration tests?
  • Do the tests cover the happy paths?
  • Do the tests cover the unhappy paths?
  • Are there an adequate number of fuzz tests to ensure that we are
    covering the full input space?
  • If matching Solidity behavior, are there differential fuzz tests that
    ensure that Rust matches Solidity?

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 3872077	Previous: dada2f9	Deviation	Status
addLiquidity: min	33893 gas	33893 gas	0%	🟰
addLiquidity: avg	144356 gas	144301 gas	0.0381%	🚨
addLiquidity: max	428319 gas	428319 gas	0%	🟰
checkpoint: min	40220 gas	40220 gas	0%	🟰
checkpoint: avg	103991 gas	104067 gas	-0.0730%	✅
checkpoint: max	212154 gas	212154 gas	0%	🟰
closeLong: min	31517 gas	31517 gas	0%	🟰
closeLong: avg	138088 gas	137774 gas	0.2279%	🚨
closeLong: max	2640435 gas	2640435 gas	0%	🟰
closeShort: min	31394 gas	31394 gas	0%	🟰
closeShort: avg	132792 gas	132727 gas	0.0490%	🚨
closeShort: max	227553 gas	227565 gas	-0.0053%	✅
initialize: min	31305 gas	31305 gas	0%	🟰
initialize: avg	253634 gas	253638 gas	-0.0016%	✅
initialize: max	322760 gas	322760 gas	0%	🟰
openLong: min	33437 gas	33437 gas	0%	🟰
openLong: avg	167194 gas	167331 gas	-0.0819%	✅
openLong: max	253057 gas	253162 gas	-0.0415%	✅
openShort: min	33959 gas	33959 gas	0%	🟰
openShort: avg	170213 gas	170153 gas	0.0353%	🚨
openShort: max	385545 gas	385650 gas	-0.0272%	✅
redeemWithdrawalShares: min	31227 gas	31227 gas	0%	🟰
redeemWithdrawalShares: avg	61882 gas	61916 gas	-0.0549%	✅
redeemWithdrawalShares: max	167572 gas	167572 gas	0%	🟰
removeLiquidity: min	31191 gas	31191 gas	0%	🟰
removeLiquidity: avg	223873 gas	223242 gas	0.2827%	🚨
removeLiquidity: max	398903 gas	398887 gas	0.0040%	🚨

This comment was automatically generated by workflow using github-action-benchmark.

[coveralls]

coverage: 93.271%. remained the same
when pulling 3872077 on dpaiton/fix-open-short
into 91d0e7f on main.

[dpaiton]

Closing in favor of rewritten PR in the hyperdrive-rs repo. delvtech/hyperdrive-rs#116