Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ dev fix création des foreign keys de la création de la table dossier_corrections #9134

Conversation

colinux
Copy link
Member

@colinux colinux commented Jun 5, 2023

C'est unsafe de créer une table avec 2 foreign keys, il vaut mieux les faire dans des migrations séparées pour pas se prendre un lock timeout

Cf https://github.com/fatkodima/online_migrations#adding-multiple-foreign-keys
et ankane/strong_migrations#187

@what-the-diff
Copy link

what-the-diff bot commented Jun 5, 2023

PR Summary

  • Added foreign keys in a later migration
    The foreign keys have been added in a separate migration step, improving the organization and structure of the project.
  • Referenced online migrations documentation
    A reference to the related online migrations documentation has been provided for clarity and better understanding of the process.

@colinux colinux added this pull request to the merge queue Jun 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2023
@colinux colinux added this pull request to the merge queue Jun 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2023
@colinux colinux added this pull request to the merge queue Jun 5, 2023
Merged via the queue into demarches-simplifiees:main with commit 08154d4 Jun 5, 2023
@colinux colinux deleted the migrate-dossier-corrections-multiple-transactions branch June 5, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants