-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] SSL Certificates #24274
Merged
adi88d
merged 46 commits into
demisto:contrib/xsoar-contrib_TerminalFin-contrib-SSLCertificates
from
xsoar-contrib:TerminalFin-contrib-SSLCertificates
Feb 7, 2023
Merged
[Marketplace Contribution] SSL Certificates #24274
adi88d
merged 46 commits into
demisto:contrib/xsoar-contrib_TerminalFin-contrib-SSLCertificates
from
xsoar-contrib:TerminalFin-contrib-SSLCertificates
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
changed the base branch from
master
to
contrib/xsoar-contrib_TerminalFin-contrib-SSLCertificates
February 1, 2023 14:25
Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @adi88d will very shortly look over your proposed changes. |
ctx = ssl.create_default_context() | ||
ctx.check_hostname = False | ||
ctx.verify_mode = ssl.CERT_OPTIONAL | ||
s = ctx.wrap_socket(socket.socket(), server_hostname=hostname) |
Check failure
Code scanning / CodeQL
Use of insecure SSL/TLS version
Insecure SSL/TLS protocol version TLSv1 allowed by [call to ssl.create_default_context](1).
Insecure SSL/TLS protocol version TLSv1_1 allowed by [call to ssl.create_default_context](1).
Contribution Pack ResubmittedContributor: @TerminalFin |
This was referenced Feb 5, 2023
@TerminalFin Please fill the Contribution Registration form |
content-bot
added
Community
Contribution Form Filled
Whether contribution form filled or not.
labels
Feb 5, 2023
Changed to DBotWeakRole context
Updated description
Updated code per previous validation errors
Updated per validation errors
Updated per validation errors
Updated per validation errors
Updated per validation errors
Updated per validation errors
Updated per validation errors
Updated per validation errors and content engineer discussions
Updated per validation errors and content engineer discussion
adi88d
approved these changes
Feb 7, 2023
adi88d
merged commit Feb 7, 2023
0ba79c1
into
demisto:contrib/xsoar-contrib_TerminalFin-contrib-SSLCertificates
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Contributor
@TerminalFin
Description
SSL Certificate Content Pack for validating SSL Certificate statuses and automatically generating CSRs to renew expiring/expired certificates.
Notes
DBotRole validation error should be ignored as it is the default role for any automation. The users of this content pack can change the user to one appropriate for their environment's RBAC implementation
Auto-Generated Documentation Requiring Modification
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.