Added more informative errors upon failures of the *upload* command #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2143
💛 - Coveralls |
yaakovi
reviewed
Mar 29, 2020
| @@ -31,19 +31,26 @@ def upload(self): | |||
| except IndexError: | |||
| print_color('Error: Path input is not a valid package directory.', LOG_COLORS.RED) | |||
| return 1 | |||
|
|
|||
| except Exception as err: | |||
| print_color(str(err), LOG_COLORS.RED) | |||
| except Exception as ex: | ||
| raise ex | ||
| except Exception as err: | ||
| print_color(str(err), LOG_COLORS.RED) |
|
|
||
|
|
||
| @patch('demisto_client.configure') | ||
| def test_upload(mocked_configure=None): |
There was a problem hiding this comment.
separate into two steps with indicative names:
test_upload_sanity
test_upload_invalid_server or test_upload_failure
optimal test: checking that an error is printed
you can try to mock print_color and check that the failure actually calls that function. I tried to in the past and it didn't work so I wouldn't have wasted time on it...
yaakovi
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Related Issues
fixes: https://github.com/demisto/etc/issues/23116
Description
in the issue