Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demisto/etc#23400: printing file path instead of file name #333

Merged
merged 2 commits into from
Apr 12, 2020

Conversation

hod-alpert
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: demisto/etc#23400

Description

There are lots of README.md files in. content repo, at least one per pack.
When messing with lots of README files it is not enough to know the base name of the file, the full path must be included.

In addition- when there are multiple files with the same names such as README.md it only shows secrets for the last one checked

@hod-alpert hod-alpert force-pushed the secrets_fix branch 2 times, most recently from d0fa1df to a728925 Compare April 6, 2020 15:27
@coveralls
Copy link
Collaborator

coveralls commented Apr 6, 2020

Pull Request Test Coverage Report for Build 2402

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.228%

Totals Coverage Status
Change from base Build 2401: 0.0%
Covered Lines: 4593
Relevant Lines: 7626

💛 - Coveralls

@Itay4
Copy link
Contributor

Itay4 commented Apr 6, 2020

lets add 2 tests:

  1. the actual path is returned and not the name
  2. that for more than one readme checked, it returns for them all

@hod-alpert hod-alpert force-pushed the secrets_fix branch 2 times, most recently from df797f8 to 5f776a8 Compare April 7, 2020 09:06
@hod-alpert
Copy link
Contributor Author

@Itay4 1 is tested in test_search_potential_secrets__secrets_found and test_ignore_entropy
Added a test for 2
in addition, added fixes to the tests to support legacy pack since it's failing the build

@Itay4
Copy link
Contributor

Itay4 commented Apr 11, 2020

@hod-alpert looks good
lets trigger a content build with secrets in 2 diff READMEs to see it works as expected

@hod-alpert
Copy link
Contributor Author

@Itay4 see here

@Itay4
Copy link
Contributor

Itay4 commented Apr 12, 2020

@Itay4 see here

excellent

@hod-alpert hod-alpert merged commit 9cf08bf into master Apr 12, 2020
@hod-alpert hod-alpert deleted the secrets_fix branch April 12, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants