Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pack content creation with unified format script/integration files #345

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Fixed pack content creation with unified format script/integration files #345

merged 7 commits into from
Apr 16, 2020

Conversation

IkaDemisto
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Fixed content_packs.zip creation with packs that include old format unified files, mostly located in Legacy pack.

@coveralls
Copy link
Collaborator

coveralls commented Apr 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2496

  • 1 of 18 (5.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 61.885%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/create_artifacts/content_creator.py 1 18 5.56%
Totals Coverage Status
Change from base Build 2495: 0.01%
Covered Lines: 4720
Relevant Lines: 7627
💛 - Coveralls

@IkaDemisto
Copy link
Contributor Author

IkaDemisto commented Apr 16, 2020 •
edited
Loading

@yuvalbenshalom triggered build in content: https://circleci.com/gh/demisto/content/48134#artifacts/containers/0. content_packs.zip zip includes unified old format integrations/scripts. You can check ipinfo or Legacy in that zip.

@IkaDemisto IkaDemisto merged commit 490bc8e into master Apr 16, 2020
@IkaDemisto IkaDemisto deleted the pack_content_creator_fix branch April 16, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakovi yaakovi yaakovi left review comments

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IkaDemisto @coveralls @yuvalbenshalom @yaakovi