Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored validate for DA #4264

Merged
merged 27 commits into from
May 16, 2024
Merged

refactored validate for DA #4264

merged 27 commits into from
May 16, 2024

Conversation

merit-maita
Copy link
Contributor

@merit-maita merit-maita commented May 7, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-7790

Description

  • Refactored all DA validations.

Copy link

github-actions bot commented May 8, 2024

Changelog(s) in markdown:

  • Added support for DA valildations in the new validation command. #4264

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, see my comment regarding the content item data.

merit-maita and others added 5 commits May 9, 2024 11:41
…ashboard_contains_necessary_fields.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…ashboard_contains_necessary_fields.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
See my comments.

@merit-maita merit-maita merged commit 0806777 into master May 16, 2024
27 checks passed
@merit-maita merit-maita deleted the refactor_DA_validators branch May 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants