Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation DS100 #4274

Merged
merged 9 commits into from
May 15, 2024
Merged

Validation DS100 #4274

merged 9 commits into from
May 15, 2024

Conversation

tkatzir
Copy link
Contributor

@tkatzir tkatzir commented May 15, 2024 •
edited
Loading

@tkatzir tkatzir requested a review from YuvHayun May 15, 2024 08:12
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Refactored validation DS100, check whether a description file exists for a beta integration. #4269

@tkatzir tkatzir requested a review from DeanArbel May 15, 2024 08:42
@tkatzir tkatzir marked this pull request as ready for review May 15, 2024 08:42
YuvHayun
YuvHayun requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Make sure to add tests as well.

.../commands/validate/validators/DS_validators/DS100_description_missing_in_beta_integration.py Outdated Show resolved Hide resolved
.../commands/validate/validators/DS_validators/DS100_description_missing_in_beta_integration.py Outdated Show resolved Hide resolved
tkatzir and others added 2 commits May 15, 2024 11:49
@tkatzir @YuvHayun
Update demisto_sdk/commands/validate/validators/DS_validators/DS100_d…
83ef6dd 
…escription_missing_in_beta_integration.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
@tkatzir @YuvHayun
Update demisto_sdk/commands/validate/validators/DS_validators/DS100_d…
aedbb14 
…escription_missing_in_beta_integration.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
@tkatzir tkatzir requested a review from YuvHayun May 15, 2024 08:50
DeanArbel
DeanArbel approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, fix error

.changelog/4274.yml Outdated Show resolved Hide resolved
@tkatzir @DeanArbel
Update .changelog/4274.yml
e0afe94 
Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Refactored validation DS100, check whether a description file exists for a beta integration. #4274

YuvHayun
YuvHayun approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

demisto_sdk/commands/validate/tests/DS_validators_test.py Outdated Show resolved Hide resolved
.../commands/validate/validators/DS_validators/DS100_description_missing_in_beta_integration.py Outdated Show resolved Hide resolved
tkatzir and others added 2 commits May 15, 2024 16:17
@tkatzir @YuvHayun
Update demisto_sdk/commands/validate/tests/DS_validators_test.py
cf2dec0 
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
@tkatzir @YuvHayun
Update demisto_sdk/commands/validate/validators/DS_validators/DS100_d…
b79f638 
…escription_missing_in_beta_integration.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
@tkatzir tkatzir merged commit 373d616 into master May 15, 2024
27 checks passed
@tkatzir tkatzir deleted the validation-ds100 branch May 15, 2024 13:40
@content-bot content-bot mentioned this pull request May 28, 2024
Merged
@israelpoli israelpoli mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanArbel DeanArbel DeanArbel approved these changes

@YuvHayun YuvHayun YuvHayun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkatzir @DeanArbel @YuvHayun