Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest docker image logic #4294

Merged
merged 13 commits into from
May 30, 2024
Merged

Fix latest docker image logic #4294

merged 13 commits into from
May 30, 2024

Conversation

DinaMeylakh
Copy link
Contributor

@DinaMeylakh DinaMeylakh commented May 23, 2024 •
edited
Loading

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10596

Description

Fix the calculation of the latest docker image. Instead of looking at the whole tag as a version, we will now decide on the latest version via the last digits of the image. Those represent the build number where the image was created and should always increase.

@DinaMeylakh
Copy link
Contributor Author

TDD: failing ut in commit 5f4045d

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed the logic for getting the latest docker image tag. #4294

@DinaMeylakh DinaMeylakh marked this pull request as ready for review May 30, 2024 06:30
@DinaMeylakh DinaMeylakh marked this pull request as draft May 30, 2024 07:26
@DinaMeylakh DinaMeylakh removed the request for review from ShahafBenYakir May 30, 2024 07:26
@DinaMeylakh DinaMeylakh marked this pull request as ready for review May 30, 2024 09:12
YuvHayun
YuvHayun approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

.changelog/4294.yml Outdated Show resolved Hide resolved
ShahafBenYakir
ShahafBenYakir approved these changes May 30, 2024
View reviewed changes
.changelog/4294.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where the latest docker image validator didn't retrieve the latest docker image version as a fix suggestion. #4294

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed the logic for retrieving the latest Docker image tag in the latest docker image validators to be determined only by the tag revision. #4294

@DinaMeylakh DinaMeylakh merged commit dad123a into master May 30, 2024
25 checks passed
@DinaMeylakh DinaMeylakh deleted the fix_docker_latest_version_logic branch May 30, 2024 11:47
@content-bot content-bot mentioned this pull request Jun 18, 2024
Merged
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Merged
This was referenced Jul 29, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

@YuvHayun YuvHayun YuvHayun approved these changes

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DinaMeylakh @ShahafBenYakir @YuvHayun