Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release notes right template support #4304

Merged
merged 10 commits into from
May 30, 2024
Merged

update release notes right template support #4304

merged 10 commits into from
May 30, 2024

Conversation

Shellyber
Copy link
Contributor

update release notes now support the right template for incident fields/types and layouts

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6077

Description

This PR changes the way update release notes create the template for incident types, incident fields, and layouts.
Before:

#### Incident Fields

- **Microsoft Sentinel Incident Number**

Now:

#### Incident Fields
##### Microsoft Sentinel Incident Number
- %%UPDATE_RN%%

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • update-release-notes command now support the right template for incident fields, incident types, and layouts. #4304

ShahafBenYakir
ShahafBenYakir reviewed May 28, 2024
View reviewed changes
demisto_sdk/commands/common/constants.py Outdated Show resolved Hide resolved
.changelog/4304.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed the update-release-notes command to support the right template for incident fields, incident types, and layouts. #4304

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed the update-release-notes command to support the right template for incident fields, incident types, layouts, generic objects, indicator types, and indicator fields. #4304

ShahafBenYakir
ShahafBenYakir reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! what about the validations? Can you check if this standard is enforced by our validate for all of these items?

@Shellyber
Copy link
Contributor Author

@ShahafBenYakir I tested everything with the new validate and the old one.
Everything seems valid after the change

ShahafBenYakir
ShahafBenYakir reviewed May 30, 2024
View reviewed changes
demisto_sdk/commands/common/tests/release_notes_test.py
@@ -785,7 +785,7 @@ def test_validate_headers(mocker, repo):
),
(
"""#### Incident Fields
- *test**
- **test**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is now invalid right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will fail

@Shellyber Shellyber merged commit cdbcdc5 into master May 30, 2024
25 checks passed
@Shellyber Shellyber deleted the incident-type-rn-template-fix branch May 30, 2024 13:24
@content-bot content-bot mentioned this pull request Jun 18, 2024
Merged
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Merged
@content-bot content-bot mentioned this pull request Jul 29, 2024
Closed
This was referenced Jul 29, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shellyber @ShahafBenYakir