Validation ds105 #4347
Merged
Validation ds105 #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
YuvHayun
approved these changes
Jun 17, 2024
.../commands/validate/validators/DS_validators/DS105_is_description_contains_contrib_details.py
Outdated
Show resolved
Hide resolved
| class IsDescriptionContainsContribDetailsValidator(BaseValidator[ContentTypes]): | ||
| error_code = "DS105" | ||
| description = "check if DESCRIPTION file contains contribution details" | ||
| rationale = "the contribution/partner details will be generated automatically and we don't want should be duplicate" |
| Given | ||
| content_items iterables. | ||
| - Case 1: description file without Contrib Details. | ||
| - Case 3: description file with Contrib Details. |
There was a problem hiding this comment.
Suggested change
| - Case 3: description file with Contrib Details. | |
| - Case 2: description file with Contrib Details. |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
https://jira-dc.paloaltonetworks.com/browse/CIAC-10562
Description