Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pb116 #4364

Merged
merged 15 commits into from
Jun 24, 2024
Merged

Add pb116 #4364

merged 15 commits into from
Jun 24, 2024

Conversation

talzich
Copy link
Contributor

@talzich talzich commented Jun 17, 2024

Description

Add new validation PB116

@talzich talzich requested a review from YuvHayun June 17, 2024 14:21
Copy link

Changelog(s) in markdown:

  • Add PB116 validation, playbook stops on error #4364

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Minor changes.

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Copy link

Changelog(s) in markdown:

  • Moved PB116 validation to the new format. the validation <what it does?>. #4364

@talzich talzich requested a review from YuvHayun June 18, 2024 07:54
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, note my comments

@talzich talzich merged commit 950be88 into master Jun 24, 2024
25 checks passed
@talzich talzich deleted the PB116 branch June 24, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants