added hardware metric tracking #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Filespoetry.lock
pyproject.toml
|
thorrester
reviewed
May 2, 2024
| from collections import namedtuple | ||
| #from opsml.projects.active_run import ActiveRun | ||
|
|
||
| LOGGER = logging.getLogger(__name__) |
There was a problem hiding this comment.
im going to change this up to use the opsml logger
thorrester
reviewed
May 2, 2024
| LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class BaseMetricsDataLogger(abc.ABC): |
|
I'm going to add some unit tests in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
========================================
Coverage 92.70% 92.70%
========================================
Files 113 114 +1
Lines 8483 8649 +166
========================================
+ Hits 7864 8018 +154
- Misses 619 631 +12
|
thorrester
approved these changes
May 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Short Summary
Added cpu, network, and memory metrics logging
Context
Concurrent hardware metric logging added to active_run. This will run in the background of an active run for its duration, continuously logging hardware metrics.