Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hw table #20

Merged
merged 15 commits into from
Jun 11, 2024
Merged

Add hw table #20

merged 15 commits into from
Jun 11, 2024

Conversation

thorrester
Copy link
Member

@thorrester thorrester commented May 29, 2024

Pull Request

Short Summary

Adds logic for putting and retrieving hardware metrics from backend dbs.

Todos

  • Add hardware metric table
  • Add Insert logic to run server
  • Update run manager to insert metrics
  • Add opsml api route to insert and get metrics
  • Add client logic to call opsml API routes for inserting and getting metrics
  • Add tests

Copy link

github-actions bot commented May 29, 2024

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

poetry.lock

NameVersionVulnerabilitySeverity
ydata-profiling4.8.3ydata unsafe deserializationhigh
ydata unsafe deserializationhigh
ydata cross-site scriptinghigh
Only included vulnerabilities with severity high or higher.

License Issues

poetry.lock

PackageVersionLicenseIssue Type
nvidia-nvjitlink-cu1212.5.40NullUnknown License
pydantic-settings2.3.2NullUnknown License

Scanned Manifest Files

poetry.lock
  • pymysql@1.1.0
  • ydata-profiling@4.8.3
  • werkzeug@3.0.2
  • ydata-profiling@4.7.0
  • jinja2@3.1.3
  • requests@2.31.0
  • aiobotocore@2.13.0
  • annotated-types@0.7.0
  • anyio@4.4.0
  • babel@2.15.0
  • bcrypt@4.1.3
  • boto3@1.34.106
  • botocore@1.34.106
  • certifi@2024.6.2
  • cloud-sql-python-connector@1.10.0
  • cryptography@42.0.8
  • datasets@2.19.2
  • fonttools@4.53.0
  • google-auth@2.30.0
  • google-cloud-storage@2.17.0
  • google-resumable-media@2.7.1
  • googleapis-common-protos@1.63.1
  • griffe@0.45.3
  • grpcio@1.64.1
  • huggingface-hub@0.23.3
  • jax@0.4.29
  • jinja2@3.1.4
  • lightning@2.2.5
  • mako@1.3.5
  • mkdocs-material@9.5.26
  • nvidia-nvjitlink-cu12@12.5.40
  • onnx@1.16.1
  • optimum@1.20.0
  • packaging@24.1
  • platformdirs@4.2.2
  • pyarrow@16.1.0
  • pydantic@2.7.3
  • pydantic-core@2.18.4
  • pydantic-settings@2.3.2
  • pygments@2.18.0
  • pymysql@1.1.1
  • pytorch-lightning@2.2.5
  • regex@2024.5.15
  • requests@2.32.3
  • scikit-learn@1.5.0
  • scipy@1.13.1
  • seaborn@0.13.2
  • setuptools@70.0.0
  • sqlalchemy@2.0.30
  • sympy@1.12.1
  • tenacity@8.3.0
  • tomlkit@0.12.5
  • torchmetrics@1.4.0.post0
  • transformers@4.41.2
  • typeguard@4.3.0
  • types-pymysql@1.1.0.20240524
  • types-requests@2.32.0.20240602
  • typing-extensions@4.12.2
  • uvicorn@0.30.1
  • watchdog@4.0.1
  • werkzeug@3.0.3
  • zarr@2.18.2
  • zipp@3.19.2
  • aiobotocore@2.12.3
  • annotated-types@0.6.0
  • anyio@4.3.0
  • babel@2.14.0
  • bcrypt@4.1.2
  • boto3@1.34.69
  • botocore@1.34.69
  • certifi@2024.2.2
  • cloud-sql-python-connector@1.9.1
  • cryptography@42.0.5
  • datasets@2.19.0
  • fonttools@4.51.0
  • google-auth@2.29.0
  • google-cloud-storage@2.16.0
  • google-resumable-media@2.7.0
  • googleapis-common-protos@1.63.0
  • griffe@0.44.0
  • grpcio@1.63.0
  • huggingface-hub@0.23.0
  • jax@0.4.26
  • lightning@2.2.4
  • mako@1.3.3
  • mkdocs-material@9.5.20
  • nvidia-nvjitlink-cu12@12.4.127
  • onnx@1.16.0
  • optimum@1.19.1
  • packaging@24.0
  • platformdirs@4.2.1
  • pyarrow@16.0.0
  • pydantic@2.7.1
  • pydantic-core@2.18.2
  • pydantic-settings@2.2.1
  • pygments@2.17.2
  • pytorch-lightning@2.2.4
  • regex@2024.4.28
  • scikit-learn@1.4.2
  • scipy@1.11.4
  • seaborn@0.12.2
  • setuptools@69.5.1
  • sqlalchemy@2.0.29
  • sympy@1.12
  • tenacity@8.2.3
  • tomlkit@0.12.4
  • torchmetrics@1.3.2
  • transformers@4.40.1
  • typeguard@4.2.1
  • types-pymysql@1.1.0.20240425
  • types-requests@2.31.0.20240406
  • typing-extensions@4.11.0
  • uvicorn@0.29.0
  • watchdog@4.0.0
  • zarr@2.17.2
  • zipp@3.18.1
pyproject.toml
  • onnx@~ 1.16.0
  • onnxruntime@~ 1.16.0
  • skl2onnx@
  • onnx@>= 1.16.0
  • onnxruntime@>= 1.13.0,< 1.17.0
  • skl2onnx@^ 1.14.1

@thorrester
Copy link
Member Author

LGTM - need to replace ydata with scouter once its ready

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 90.29851% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (cded397) to head (5fd246b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   91.56%   91.52%   -0.04%     
==========================================
  Files         114      115       +1     
  Lines        9136     9212      +76     
==========================================
+ Hits         8365     8431      +66     
- Misses        771      781      +10     
Files Coverage Δ
opsml/app/routes/pydantic_models.py 100.00% <100.00%> (ø)
opsml/cards/run.py 93.81% <100.00%> (+0.09%) ⬆️
opsml/helpers/gcp_utils.py 100.00% <100.00%> (ø)
opsml/projects/_hw_metrics.py 92.12% <100.00%> (-1.17%) ⬇️
opsml/projects/_run_manager.py 96.55% <100.00%> (ø)
opsml/registry/records.py 100.00% <ø> (ø)
opsml/registry/sql/base/client.py 93.25% <100.00%> (+0.25%) ⬆️
opsml/registry/sql/base/server.py 95.91% <100.00%> (+0.12%) ⬆️
opsml/registry/sql/connectors/base.py 88.88% <100.00%> (+0.13%) ⬆️
opsml/storage/card_loader.py 89.05% <ø> (-0.04%) ⬇️
... and 8 more

@thorrester thorrester mentioned this pull request Jun 11, 2024
@thorrester thorrester marked this pull request as ready for review June 11, 2024 20:04
@thorrester thorrester merged commit ff888d4 into main Jun 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants