-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reqs and ModelInterface sample_data
#32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
License Issuespoetry.lock
pyproject.toml
Scanned Manifest Files.github/workflows/lint-unit-tests.yml
poetry.lock
pyproject.toml
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 91.51% 91.10% -0.41%
==========================================
Files 115 115
Lines 9213 9374 +161
==========================================
+ Hits 8431 8540 +109
- Misses 782 834 +52
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Short Summary
Reqs
Updating reqs to handle latest tensorflow version and fiasco. Tensorflow moved to a keras 3 backend which has broken a few things when it comes to architecture compatibility.
HuggingFace has not updated their library to handle Keras 3, so we need to install
tf-keras
for the time being for backward compatibility. This works on linux, but this appears to prevent tensorflow from running on macos. There's also issues with arm at the moment. We'll need to keep an eye out.ModelInterface
sample_data
is currently saved as a joblib artifact. A better solution would be to put the providedsample_data
into aDataInterface
class and save the data as it's associated library intends. To do this, we had to add in some logic that attempts to determin if the provided data is one of the supportDataInterface
subclasses. If so, the data is added to the interface and the interface is added tosample_data
attribute. If interface is not determined, logic falls back to joblib. Saving and loading data have been updated as well.