Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve repository code re-usability #168

Open
joorei opened this issue Jun 13, 2024 · 0 comments
Open

Improve repository code re-usability #168

joorei opened this issue Jun 13, 2024 · 0 comments
Assignees
@joorei
Labels
quality improvement Enhancement of existing features
Milestone
0.27.0

Comments

@joorei
Copy link
Collaborator

joorei commented Jun 13, 2024

Much of the code in PhpEntityRepository is simply based on the OffsetEntityProviderInterface. By moving it into an abstract repository class, it can be used in other repositories as well.
@joorei joorei added the quality improvement Enhancement of existing features label Jun 13, 2024
@joorei joorei added this to the 0.27.0 milestone Jun 13, 2024
@joorei joorei self-assigned this Jun 13, 2024
joorei added a commit to joorei/edt that referenced this issue Jun 13, 2024
@joorei
refactor(repository): extract code into abstract class
3acf42b 
Most of the code in `PhpEntityRepository` is relevant
for other repositories based on an entity provider
too. Hence, the re-usable logic was moved into a
newly created abstract class.

Refs: demos-europe#168
@joorei joorei mentioned this issue Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joorei joorei

Labels
quality improvement Enhancement of existing features
Projects
None yet
Milestone
0.27.0
Development

No branches or pull requests
1 participant
@joorei