Patterns documentation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoth
commented
Jun 20, 2021
| @@ -147,9 +147,9 @@ private static void SV_Configstrings_f(List<String> args, GameImportsImpl gameIm | |||
| final String nextCmd; | |||
|
|
|||
| if (start == Defines.MAX_CONFIGSTRINGS) { | |||
| nextCmd = "cmd baselines " + gameImports.spawncount + " 0\n"; | |||
| nextCmd = "cmd " + StringCmdMessage.BASELINES + " " + gameImports.spawncount + " 0\n"; | |||
There was a problem hiding this comment.
easier to track usages this way
There was a problem hiding this comment.
Why not use the string templating?
Suggested change
| nextCmd = "cmd " + StringCmdMessage.BASELINES + " " + gameImports.spawncount + " 0\n"; | |
| nextCmd = String.format("cmd %s %s 0\n", StringCmdMessage.BASELINES, gameImports.spawncount); |
samoylovfp
reviewed
Jun 20, 2021
info/Overview.md
Outdated
| Although the performance of jake2 is not a problem at the moment (mostly because it uses too little resources), | ||
| splitting io and non io operation will improve execution structure. | ||
| Introduction of non blocking io can improve resource consumption even more. |
There was a problem hiding this comment.
This statement needed clarification
samoylovfp
approved these changes
Jun 20, 2021
improved threading section
demoth
force-pushed
the
feature/patterns-doc
branch
from
10e1fe7
to
b149108
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.