Create new GameImports/GameExports instance every time new map is created #69
Conversation
+ Config string type description
| @Override | ||
| public void fromPrevious(GameExports oldGame) { | ||
| GameExportsImpl oldGameImpl = (GameExportsImpl) oldGame; | ||
| // assert both client arrays are of the same size |
There was a problem hiding this comment.
This is not clear.
Feels like there should be an assert here and then only one length should be checked in the for condition.
qcommon/src/main/java/jake2/qcommon/network/messages/NetworkPacket.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public String getType(int index) { | ||
| if (index == CS_NAME) { |
There was a problem hiding this comment.
I wonder if there is a way to generate this switch
| return "CS_MAXCLIENTS"; | ||
| } else if (index == CS_MAPCHECKSUM) { | ||
| return "CS_MAPCHECKSUM"; | ||
| } else if (index < CS_SOUNDS) { |
| @@ -44,12 +44,12 @@ public SV_GAME(GameImportsImpl gameImports) { | |||
| * | |||
| * Sends the contents of the mutlicast buffer to a single client. | |||
| */ | |||
| public void PF_Unicast(int p, boolean reliable, NetworkMessage msg) { | |||
| public void PF_Unicast(int index, boolean reliable, NetworkMessage msg) { | |||
There was a problem hiding this comment.
Reminds me of the Hlopin naming convention
| if (cl.state == ClientStates.CS_FREE) { | ||
| index = i; | ||
| break; | ||
| } | ||
| i++; |
There was a problem hiding this comment.
I wonder if ListIterator is more idiomatic
https://stackoverflow.com/questions/7167253/is-there-a-java-equivalent-of-pythons-enumerate-function
There was a problem hiding this comment.
Yea, looks ugly - i guess it's the only place where index is required - everywhere else i managed to use for each. Anyway - its' the subject to change in nearest future
| final client_t client = clients.get(i); | ||
| client.edict = ent; | ||
| edict_t ent = gameImports.gameExports.getEdict(i + 1); | ||
| client.edict = ent; // fixme: why? isn't it already set? |
| if (cl.edict != null) { // free client slots will have null values | ||
| cl.edict.inuse = savedInuse[i]; | ||
| } | ||
| i++; |
There was a problem hiding this comment.
Same question about ListIterator
…cket.java Co-authored-by: samoylovfp <samoylovfp@gmail.com>
Do not reuse the same instance of GameImports/GameExports between maps
Also fixed: