-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow manual seeding of leaves #8
Comments
Actually, this could be done e.g. by a custom function as suggested in #7 |
Reading #7 reminded me of this. Perhaps both can be addressed using callback functions |
@ChrisBeaumont - yes, in fact what I was suggesting is that all one needs to do in the scenario of #7 and the implementation of #10 is pass a function that will only accept a leaf as independent if it contains one of a list of seed pixels. However, I do agree that it would be nice to make this a little easier to use that requiring the user to have to write a custom function. We could either:
|
Do we still want to go with the second option now we've said (in other issues) that re-computing is preferable for now to pruning? |
Maybe not. Option 3 would be the simplest interface, since we want to use custom merger functions anyways. I think we should merge that code, and then make sure it's easy to use a custom merge test function to build a dendrogram with manually-specified seeds |
Closed via #10 |
A feature I would find useful is the ability to pass a list of seed pixels to
compute
. The dendrogram would then be constructed in such a way that each leaf contains exactly one seed pixel. This would be helpful for, e.g., resolution studies.The text was updated successfully, but these errors were encountered: