Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better icon placement in the Tree View #767

Open
2 of 8 tasks
aleksey-rowan opened this issue May 26, 2021 · 3 comments
Open
2 of 8 tasks

Better icon placement in the Tree View #767

aleksey-rowan opened this issue May 26, 2021 · 3 comments
Labels
area.misc type.enhancement Extension to a previously shipped feature. Minor functionality update.
Milestone

Comments

@aleksey-rowan
Copy link
Contributor

aleksey-rowan commented May 26, 2021

Please Select if your Request is Either something new or an Enhancement

  • Enhancement of an existing Feature.
  • Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

  • Onboard. Initial vault setup and import/export pods
  • Create. Note creation, lookup, snippets and templates
  • Retrieve. Backlinks, references, graph view
  • Structure. Refactoring, multi-vault and schemas
  • Publish. Sharing your repo with the world
  • Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe

As I understand, the schema-added icons in the Dendron tree view perform a different role as compared to VSCode file type icons in its explorer view. Since every file has a type (even file with unknown types are given a placeholder icon), each entry in the explorer view will have an icon and folder icons can additionally indicate that something can be expanded:

In the Dendron tree, an icon just indicates a relation to an existing schema and both leaf and non-leaf nodes can have the same icons. Since not all nodes have icons, the tree view gets confusing at times when it's not possible to tell visually the structure of the node.

Consider this structure:

  • one
    • four
    • three
      • blah
        • foo
      • five
    • two

The above renders as follows:

In the image, the node two seems to belong to the node five which is not the case.

I think indenting of some nodes with icons and not indenting others leads to this confusion as node labels are not longer reliably aligned.

If all nodes are given an icon (even an empty square one), like in the explorer view, then the problem goes away, but the tree becomes too visually cluttered since most of the icons are not needed.

Describe the solution you'd like

As an alternative, I suggest moving the schema-added icon to the right of the node name which makes the hierarchy cleanly visible and schema icons scannable at a glance as they are right-aligned:

Additional context

As an added benefit, it would be harder to accidentally click the + button that creates an actual note from a stub. I'm not sure about others, but I often do that when working with the tree.

@github-actions github-actions bot added area.misc status.triage-needed type.enhancement Extension to a previously shipped feature. Minor functionality update. labels May 26, 2021
@kpathakota
Copy link
Contributor

oh wow, I really like this idea! Thanks @aleksey-rowan

@wookiefriseur
Copy link
Contributor

Somewhat connected to this issue:

It would be nice if there was some highlight depending on the note type.

For instance something like this for tasks and their status in the tree view:
grafik

Just an example (not colour blindness compatible).

I can create a new issue if this is unconnected.

@ghost
Copy link

ghost commented Oct 29, 2022

image

Perhaps instead of the plus symbol, the folder without a note could be slightly darker like in github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area.misc type.enhancement Extension to a previously shipped feature. Minor functionality update.
Projects
None yet
Development

No branches or pull requests

3 participants