fix: store listen addresses as reported by identify #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
fix-listen-addresses
branch
from
94a4f03
to
66bf58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When crawling the DHT I’m constantly issuing
FIND_NODERPCs. The response contains a list of peerIDs and also often the multi addresses. If the peer that returns the response is on an older version that doesn’t support, e.g.,/quic-v1, the list of multi addresses won’t contain such addresses although the returned peer might actually support it.The list I’m currently tracking with Nebula is the one I got handed by the other peer.
With this PR, I adjusted the crawler to await the Identify exchange and store the Multiaddresses that the peer actually reports to listen on.