feat: support for specifying additional TLS certs #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soremwar
requested changes
Aug 2, 2021
This commit adds support for specifying additional certificates (like required for servers with self signed certs), to the client. The certificate will be passed to `Deno.startTls` appropriately.
lucacasonato
force-pushed
the
custom_tls_certs
branch
4 times, most recently
from
44513dd
to
0c0038a
Compare
lucacasonato
force-pushed
the
custom_tls_certs
branch
from
0c0038a
to
d04dcb8
Compare
Soremwar
requested changes
Sep 25, 2021
|
@lucacasonato Please rebase over latest main, it contains an important fix for TLS connection and the Deno version bump |
This commit adds support for specifying additional certificates (like required for servers with self signed certs), to the client. The certificate will be passed to `Deno.startTls` appropriately.
Soremwar
force-pushed
the
custom_tls_certs
branch
from
4c09418
to
51f7672
Compare
This reverts commit 1ae3a82.
…nto custom_tls_certs
Soremwar
approved these changes
Sep 28, 2021
|
Thanks for seeing this through @Soremwar :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for specifying additional certificates
(like required for servers with self signed certs), to the client.
The certificate will be passed to
Deno.startTlsappropriately.Closes #284