Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use caCertificates instead of caFile #340

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

lucacasonato
Copy link
Contributor

@lucacasonato lucacasonato commented Oct 4, 2021

In Deno 1.15 CA files can be specified as PEM encoded cert
strings, rather than as file paths to the PEM encoded certs.

See denoland/deno@0d7a417

Dependant on #345.

@lucacasonato lucacasonato changed the title chore: use caCerts instead of caFile feat: use caCerts instead of caFile Oct 16, 2021
docs/README.md Show resolved Hide resolved
connection/connection_params.ts Outdated Show resolved Hide resolved
connection/connection_params.ts Outdated Show resolved Hide resolved
connection/connection.ts Outdated Show resolved Hide resolved
tests/data_types_test.ts Outdated Show resolved Hide resolved
@lucacasonato lucacasonato force-pushed the cacerts_instead_of_cafile branch 5 times, most recently from 3484284 to f6faf9a Compare November 8, 2021 18:02
@lucacasonato lucacasonato changed the title feat: use caCerts instead of caFile feat: use caCertificates instead of caFile Nov 8, 2021
In Deno 1.15 CA files can be specified as PEM encoded cert
strings, rather than as file paths to the PEM encoded certs.
Copy link
Collaborator

@Soremwar Soremwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you luca

@Soremwar Soremwar merged commit 3e6e824 into denodrivers:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants