feat: #310 camelcase option #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soremwar
requested changes
Oct 7, 2021
| @@ -520,6 +520,74 @@ testClient( | |||
| }, | |||
| ); | |||
|
|
|||
| testClient( | |||
There was a problem hiding this comment.
This and the following test are redundant, please leave just one
| }, | ||
| ); | ||
|
|
||
| testClient( |
There was a problem hiding this comment.
Add a test for a field that has no name, somthing like "SELECT 1, 2, 3". I wanna know how this behaves for auto generated field names
query/query.ts
Outdated
| @@ -151,6 +152,21 @@ export class QueryObjectResult< | |||
| > extends QueryResult { | |||
| public rows: T[] = []; | |||
|
|
|||
| private _snakeToCamelCase = (input: string) => | |||
There was a problem hiding this comment.
We don't use TypeScript privates here, we use JavaScript privates
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
Soremwar
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made new fork as the old one was way too old.
Implemented camelcase option in QueryObjectConfig, added unit tests for camelcase (without, false, true).
BR