PubSub with binary messages

[darrachequesne]

Hi!

Is there a way to put a subscription in binary mode?

import { connect } from "https://deno.land/x/redis@v0.27.0/mod.ts";

const pubClient = await connect({ hostname: "localhost" });
const subClient = await connect({ hostname: "localhost" });

subClient.subscribe("channel").then(async (sub) => {
    for await (const { message } of sub.receive()) {
        console.log(message); // prints "e�"
    }
});

setTimeout(() => {
    pubClient.publish("channel", Uint8Array.from([1, 101, 201]));
}, 200);

Node.js with redis:

import { createClient } from "redis";

const pubClient = createClient({ url: "redis://localhost:6379" });
const subClient = pubClient.duplicate();

await Promise.all([pubClient.connect(), subClient.connect()]);

await subClient.subscribe("channel", (message) => {
    console.log(message); // prints "<Buffer 01 65 c9>"
}, true);

await pubClient.publish("channel", Buffer.from([1, 101, 201]));

Update: I don't think this is currently possible, as the response from the server is decoded with a TextDecoder:

redis/protocol/reply.ts

Lines 106 to 108 in 878c883

	override bulk() {
	return this.#body ? decoder.decode(this.#body) : null;
	}

redis/protocol/reply.ts

Lines 243 to 246 in 878c883

	case BulkReplyCode: {
	const reply = await BulkReply.decode(reader);
	array.push(reply.bulk());
	break;

[uki00a]

@darrachequesne Hi, sorry for the late response.

deno-redis currently doesn't support PubSub with binary messages. However, I'll consider supporting this as it would be useful 👍