Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix concurrent pipeline invocation results #429

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

yahiro07
Copy link
Contributor

@yahiro07 yahiro07 commented Mar 15, 2024

This PR fixes mixed response problem for parallel pipeline calls.

I made the modification so as the pipeline calls queued in the same way as regular commands.
To achieve this, the type of command queue item has changed to hold a general lambda function.

In my previous branch (yahiro07:pipeline-parallel-execution), there is a problem it doesn't work with Redis 6.
In this branch (yahiro07:pipeline-parallel-execution-2), I confirmed it works with both Redis 6 and Redis 7.

Please check:

  • The test fails if you only add the test code.
  • The test passes if you apply whole changes.

Closes #427

@yahiro07 yahiro07 marked this pull request as ready for review March 15, 2024 19:38
@uki00a uki00a merged commit 28ead06 into denodrivers:master Mar 16, 2024
2 checks passed
@uki00a
Copy link
Member

uki00a commented Mar 16, 2024

@yahiro07 LGTM and thanks! 👍 v0.32.2 has been released which includes this fix.

@yahiro07
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors on concurrent pipeline invocation
2 participants