fix: use proper xid types for xpending range #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A range that can be used in
XPENDING
is defined the same way as inXRANGE
.Currently, when calling
xpendingCount
thestart
andend
arguments havenumber | "-"
type, which prevents users from specifying other valid forms ofXIdInput
and indicates that the method cannot process anXId
object.Proposed changes
start
andend
toXIdNeg
andXIdPos
accordingly, just like it's done forxrange
.start
andend
arguments withxidstr
that would transform a validxIdInput
to string ID.