Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper xid types for xpending range #436

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

ArturSharapov
Copy link
Contributor

A range that can be used in XPENDING is defined the same way as in XRANGE.

Currently, when calling xpendingCount the start and end arguments have number | "-" type, which prevents users from specifying other valid forms of XIdInput and indicates that the method cannot process an XId object.

Proposed changes

  • Update type definitions of start and end to XIdNeg and XIdPos accordingly, just like it's done for xrange.
  • Wrap start and end arguments with xidstr that would transform a valid xIdInput to string ID.

@uki00a uki00a added the bug Something isn't working label Jun 29, 2024
@uki00a uki00a merged commit 287f5df into denodrivers:master Jun 29, 2024
2 checks passed
@uki00a
Copy link
Member

uki00a commented Jun 29, 2024

LGTM! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants