Reduce bundle size #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Mar 2, 2022
style/main.scss
Outdated
Comment on lines
11
to
17
| ol { | ||
| list-style: decimal; | ||
| } | ||
|
|
||
| ul { | ||
| list-style: disc; | ||
| } |
There was a problem hiding this comment.
This is added in f4c4470 and actually not necessary.
I assume you looked at a website with CSS reset (e.g. Tailwind's Preflight) and made the wrong assumption that they are needed.
There was a problem hiding this comment.
Why is this not needed? If you are using this on a site with Tailwind's preflight, won't the list style be unset?
There was a problem hiding this comment.
kidonng
changed the title
@primer/css with github-markdown-css
lucacasonato
reviewed
Mar 3, 2022
style/makefile
Outdated
Comment on lines
1
to
10
| patch: | ||
| mkdir -p dist | ||
| # Extract variables used by Markdown | ||
| grep -Eoh -- "--[[:alnum:]-]+" node_modules/@primer/css/markdown/*.scss | sort -u > dist/variables | ||
| # Extract variables used by ourselves | ||
| grep -Eoh -- "--[[:alnum:]-]+" main.scss | sort -u >> dist/variables | ||
| # Patch light colors | ||
| echo "@mixin primer-colors-light {\n & {\n`grep -f dist/variables node_modules/@primer/primitives/dist/scss/colors/_light.scss`\n }\n}" > node_modules/@primer/primitives/dist/scss/colors/_light.scss | ||
| # Patch dark colors | ||
| echo "@mixin primer-colors-dark {\n & {\n`grep -f dist/variables node_modules/@primer/primitives/dist/scss/colors/_dark.scss`\n }\n}" > node_modules/@primer/primitives/dist/scss/colors/_dark.scss |
There was a problem hiding this comment.
Instead of this being a makefile, could you turn this into a Deno script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing styles directly from
@primer/cssresults in tons of unused CSS variables and rules being included in the bundle.This PR tries to reduce the bundle size by patching the colors stylesheet to only include colors we actually use: