Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx precompile: double escape bug #22577

Closed
c-antin opened this issue Feb 25, 2024 · 0 comments · Fixed by denoland/deno_ast#213
Closed

jsx precompile: double escape bug #22577

c-antin opened this issue Feb 25, 2024 · 0 comments · Fixed by denoland/deno_ast#213
Assignees
@marvinhagemeister

Comments

@c-antin
Copy link

c-antin commented Feb 25, 2024

Version: Deno 1.41.0

If a jsx function component uses props.children the precompiled jsx template string is escaped twice.
Furthermore, using preact/jsx-runtime the resulting html is either empty or escaped threefold.

Steps to reproduce: see repo https://github.com/c-antin/jsx_precompile_bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinhagemeister marvinhagemeister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: precompile don't escape component text children denoland/deno_ast
2 participants
@marvinhagemeister @c-antin