Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno compile doesn't handle node unstable flags #22585

Open
sigmaSd opened this issue Feb 26, 2024 · 3 comments
Open

deno compile doesn't handle node unstable flags #22585

sigmaSd opened this issue Feb 26, 2024 · 3 comments
Labels
bug Something isn't working correctly compile related to the `deno compile` feature

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented Feb 26, 2024

Version: Deno 1.41.0

deno compile --no-check --unstable-sloppy-imports --unstable-bare-node-builtins

Running the executable that uses this fails with

error: Module not found:

also here is a repo to test it, https://github.com/sigmaSd/helix-gpt/

  • use the deno branch
  • compile with
deno compile --no-check --unstable-sloppy-imports --unstable-bare-node-builtins --allow-env src/app.ts
  • run ./app
    it errors with
error: Module not found: file:///home/mrcool/dev/others/helix-gpt/src/deno-compat
@lucacasonato lucacasonato added bug Something isn't working correctly compile related to the `deno compile` feature labels Jun 12, 2024
@HasanAlrimawi
Copy link
Contributor

Hello @sigmaSd,
I tried to reproduce the issue, but got this error instead the one you mentioned:
Issue Reproduction
Any thoughts?

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Aug 1, 2024

Hello, that branch have been updated and no longer use the unstable flags

The error you're having is because you're not choosing a handler (with --handler codeium for example)

I don't know if this issue is still present though since I didn't try compiling with unstable flags in a while

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Aug 4, 2024

To reproduce on that repo, I run git checkout 24d46012160e320e512c593a7bc747af540f5520

I tried with the latest deno version, it now shows a warning that its not supported

Warning Sloppy imports are not supported in deno compile. The compiled executable may encouter runtime errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly compile related to the `deno compile` feature
Projects
None yet
Development

No branches or pull requests

3 participants