Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test "inspector_with_ts_files" is flaky #23994

Closed
bartlomieju opened this issue May 27, 2024 · 1 comment · Fixed by #24015
Closed

test "inspector_with_ts_files" is flaky #23994

bartlomieju opened this issue May 27, 2024 · 1 comment · Fixed by #24015
Labels
flaky a test is not reliable or determinstic tests related to tests

Comments

@bartlomieju
Copy link
Member

https://github.com/denoland/deno/actions/runs/9260046276/job/25473086311?pr=23903

---- inspector::inspector_with_ts_files stdout ----
command /home/runner/work/deno/deno/target/release/deno run --check --inspect-brk=127.0.0.1:9242 /home/runner/work/deno/deno/tests/testdata/inspector/test.ts
command cwd /home/runner/work/deno/deno/tests
STDERR: Check file:///home/runner/work/deno/deno/tests/testdata/inspector/test.ts
STDERR: Debugger listening on ws://127.0.0.1:9242/ws/739298f1-3ddd-4b24-a3c9-ab4c71c16883
STDERR: Visit chrome://inspect to connect to the debugger.
STDERR: Deno is waiting for debugger to connect.
STDERR: Debugger session started.
STDOUT: hello
STDOUT: world
STDERR: Program finished. Waiting for inspector to disconnect to exit the process...
thread 'inspector::inspector_with_ts_files' panicked at tests/integration/inspector_tests.rs:1017:3:
"Program finished. Waiting for inspector to disconnect to exit the process..." does not contain any of ["Check"]
@bartlomieju bartlomieju added tests related to tests flaky a test is not reliable or determinstic labels May 27, 2024
@marvinhagemeister
Copy link
Contributor

Also failed here: https://github.com/denoland/deno/actions/runs/9267808799/job/25495090008?pr=24009

Looking into it, it's caused by type checking finishing before the inspector stuff. There is no guarantee that one or the other finishes first, but we expect type checking to only be done after the inspector stuff in our tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky a test is not reliable or determinstic tests related to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants