Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert and CFA #2715

Closed
kitsonk opened this issue Aug 4, 2019 · 3 comments
Closed

assert and CFA #2715

kitsonk opened this issue Aug 4, 2019 · 3 comments

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 4, 2019

Tracking issue.

After originally indicating it was a design limitation, the TypeScript team revisited allowing the ability to model type narrowing via assert(). The assert() pattern is heavily used within Deno and once microsoft/TypeScript#32695 is landed is part of a TypeScript release we will be able to make all of our code more sound.
@hayd
Copy link
Contributor

hayd commented Sep 24, 2019

Update: This is merged to TS.

@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 24, 2019

🎉 then that means it will be part of 3.7. There is a lot of code we will want to update on the back of it!!!

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 31, 2020

Implemented in code base now. Closing.

@kitsonk kitsonk closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kitsonk @hayd