Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between types and code in new Compiler API #3702

Closed
klaushvam opened this issue Jan 17, 2020 · 1 comment · Fixed by #3703
Closed

Inconsistency between types and code in new Compiler API #3702

klaushvam opened this issue Jan 17, 2020 · 1 comment · Fixed by #3703

Comments

@klaushvam
Copy link
Contributor

klaushvam commented Jan 17, 2020 •
edited
Loading

While testing out the new Compiler API #3442 i ran into some inconsistency between the typings and the returned data for diagnostics.

Deno.compile is defined type wise to return Diagnostic[](https://github.com/denoland/deno/blob/master/cli/js/compiler_api.ts#L331), but code implemented returns DiagnosticItem[] (https://github.com/denoland/deno/blob/master/cli/js/compiler.ts#L245)
@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Jan 17, 2020 •
edited
Loading

Ref #3624. Technically not duplicate, looks like it's not just bundle.

cc @kitsonk

@klaushvam klaushvam mentioned this issue Jan 17, 2020
Merged
@ry ry closed this as completed in #3703 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile and bundle api types
2 participants
@klaushvam @nayeemrmn