fix(ext/crypto): throw on key & op algo mismatch #12838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
commented
Nov 22, 2021
tools/wpt/expectation.json
Outdated
Comment on lines
3093
to
3095
| "AES-CBC 128-bit key with mismatched key and algorithm", | ||
| "AES-CBC 192-bit key with mismatched key and algorithm", | ||
| "AES-CBC 256-bit key with mismatched key and algorithm", |
There was a problem hiding this comment.
These fail because AES-CTR is not implemented.
littledivy
reviewed
Nov 22, 2021
littledivy
approved these changes
Nov 22, 2021
bnoordhuis
approved these changes
Nov 25, 2021
lucacasonato
added a commit
to lucacasonato/deno
that referenced
this pull request
Dec 3, 2021
lucacasonato
added a commit
to lucacasonato/deno
that referenced
this pull request
Dec 3, 2021
lucacasonato
added a commit
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw when key and operation algorithm do not match.
Specified here: https://w3c.github.io/webcrypto/#dfn-SubtleCrypto-method-decrypt
Tested via WPT