backport changes for 1.16 #12981
Merged
backport changes for 1.16 #12981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Dec 3, 2021
Reduce the number of iterations from 1,024 to 128. On my big bruiser of a desktop machine it already takes up close to a minute to complete when nothing else is running so no way it's going to finish in the allotted time on the CI. The fact that the test used to pass may be indicative of a performance regression somewhere but it's not clear to me when or where that would have been introduced. Fixes denoland#12887.
More clean up that should have been in cc83ad3
lucacasonato
force-pushed
the
backport_1.16
branch
from
e602641
to
14920af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.