std/installer: add basic uninstaller #3804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
force-pushed
the
std/installer/uninstall
branch
from
5191290
to
8b87894
Compare
|
Maybe this should be a flag on install? |
|
@nayeemrmn I feel having a flag like |
|
@kevinkassimo thanks - waiting to land #3806 first - maybe its better if this is done in rust - but let's just wait until that patch lands. |
|
@ry Sure. I'll probably reimplement in Rust if that PR is accepted. |
|
FYI #3806 has been landed |
|
See #3850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a very basic uninstaller that mirrors the installer, making removal slightly easier.
(Technically this is similar to
rm $(which file_server), but based on Gitter conversations it seems that not everyone is familiar with using the shell, and the command might remove other binaries of same name)