/deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format files in tests/ #531

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Reviewers

@ry ry

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@kt3k @kitsonk @ry
@kt3k
Copy link
Contributor

kt3k commented Aug 16, 2018

resolves #525
@kitsonk

This comment has been minimized.

Sign in to view
Copy link
Contributor

kitsonk commented Aug 16, 2018

My personal feeling is that we potentially want bad formatting in the /tests as it helps ensure that such things do not matter to the runtime.
@kt3k
chore: format files in tests/
Loading status checks…
88d37ed

@kt3k kt3k force-pushed the kt3k:feature/format-tests branch from a122e83 to 88d37ed Aug 17, 2018

@kt3k

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

kt3k commented Aug 17, 2018

@kitsonk I agree. In that case, I think we can use .prettierignore file for avoiding formatting of them.
@ry

ry approved these changes Aug 17, 2018
View changes

Copy link
Collaborator

ry left a comment

LGTM
@kitsonk Good point. @kt3k Good solution.

@ry ry merged commit 565a21e into denoland:master Aug 17, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/format-tests branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment