Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format files in tests/ #531

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Format files in tests/ #531

merged 1 commit into from
Aug 17, 2018

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Aug 16, 2018

resolves #525

@kitsonk
Copy link
Contributor

kitsonk commented Aug 16, 2018

My personal feeling is that we potentially want bad formatting in the /tests as it helps ensure that such things do not matter to the runtime.

@kt3k
Copy link
Member Author

kt3k commented Aug 17, 2018

@kitsonk I agree. In that case, I think we can use .prettierignore file for avoiding formatting of them.

ry
ry approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kitsonk Good point. @kt3k Good solution.

@ry ry merged commit 565a21e into denoland:master Aug 17, 2018
@kt3k kt3k deleted the feature/format-tests branch August 17, 2018 22:02
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@zekth @ry
fix emptydir on windows (denoland#531)
67641b8
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
@bartlomieju
refactor: use v8::OneByteConst (denoland#531)
8c19f5e 
Closes denoland/deno_core#527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tools/format.py should also format code in tests/
3 participants
@kt3k @kitsonk @ry