-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to patch jsr packages with local copies #100
Conversation
…n't know this infomration at this point
…se we don't know this infomration at this point" This reverts commit f39218c.
json!({ | ||
"patch": ["../dir"], | ||
}), | ||
json!({ | ||
"patch": [ | ||
"../../dir" | ||
], | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this confusing. From what I can tell, you can specify a path to a directory that contains one or more packages that should be used for "patching". But to see which packages will actually be patched I need to go to that directory and look up all the configs to figure out the names.
Is there a reason why you went with a list for patch directories instead of having to specify a mapping between package name and its patch directory instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems confusing because the test has the name dir
. Usually the directory name would be something like ../deno_std/path
or something like that. The user having to specify the package name in addition to the directory just seems like unnecessary bookkeeping since we can already tell the package name from the directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okayi guess that's reaaonable
For denoland/deno#23412
Allows specifying the directory to another package or workspace similar to patch in cargo (https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html).