[WIP] destrucutre AggregateError #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Jan 9, 2024
| await Promise.any([]); | ||
| })() | ||
| "#; | ||
| let value_global = runtime |
There was a problem hiding this comment.
Any chance these could be integration and/or unit tests? I'd like to avoid adding more of these tests which are a bit awkward to maintain in Rust.
|
@littledivy did more digging into this problem and our current understanding is that it's a V8 problem - not sure if it's worth investing resources right now to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second test, which uses
destructureError(underlying op beingop_destructure_error), adds a frame for unknown reasons.Additionally, for some reason,
AggregregateErrors don't have any stack frames.