Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove serde_v8 benchmarks #745

Merged
merged 1 commit into from
May 16, 2024

Conversation

bartlomieju
Copy link
Member

As per #716 we are working
on replacing serde_v8 with a new mechanism completely.

To that end, running benchmarks now is not that useful and only adds to
the overall CI time.

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) May 16, 2024 22:27
@bartlomieju bartlomieju merged commit 87e5ab2 into denoland:main May 16, 2024
18 checks passed
@bartlomieju bartlomieju deleted the remove_serde_v8_benchmarks branch May 16, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants