store ContextState and ModuleMap in embedder slots
#772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
commented
Jun 7, 2024
bartlomieju
approved these changes
Jun 7, 2024
bartlomieju
added a commit
that referenced
this pull request
Jun 7, 2024
#776) This reverts commit 98d52cf. CC @littledivy I had trouble updating `deno_core` in Deno as it died on `node_unit_tests::vm_test` with signal 11 during `vm context promise rejection` test. Also `Box<Rc<...>>` seems fishy as pointed as by @dsherret in #775 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of rusty_v8 annex slots for storing
ContextStateandModuleMapand instead store them directly in a dedicated embedder field.Needed for denoland/deno#23976