Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update swc dependencies #28

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Sep 23, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before updating deno_doc in deno we'll have to bump deno_lint and dprint-plugin-typescript to matching SWC version

@nayeemrmn
Copy link
Contributor

nayeemrmn commented Sep 23, 2020

Could we delay these upgrades for swc-project/swc#1101 (swc_ecmascript v0.8.1)? We can then revert denoland/deno#7413.

Cargo.toml Outdated
swc_common = { version = "=0.10.2" }
swc_ecmascript = { version = "=0.7.7", features = ["parser"] }
swc_common = { version = "=0.10.3" }
swc_ecmascript = { version = "=0.8.0", features = ["parser"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
swc_ecmascript = { version = "=0.8.0", features = ["parser"] }
swc_ecmascript = { version = "=0.8.1", features = ["parser"] }

@bartlomieju bartlomieju merged commit 6d39fac into denoland:main Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants