feat: move text encoding functionality into deno_graph::source from CLI
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jan 31, 2024
| return MediaType::Unknown; | ||
| }; | ||
| MediaType::from_content_type( | ||
| &ModuleSpecifier::parse("data:image/png;base64,").unwrap(), |
There was a problem hiding this comment.
Is this just to satisfy the type system? Can there be a situation where this will return wrong value? (I guess it will return Unknown if content_type is not recognized)
There was a problem hiding this comment.
Ah, yeah I'll add a comment, todo, and open an issue in media_type to improve this. Yeah, it just gets ignored.
There was a problem hiding this comment.
Actually, I'll just add a comment here. This is extremely edge casey and in 99% of cases someone should be providing a specifier to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this into the CLI allows me to delete some CLI code and re-use the functionality that's already in this crate.