Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: follow_fast_check_modules option for conditional walking of fast check modules #431

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat: follow_fast_check_modules option for conditional walking of fast check modules #431

merged 2 commits into from
Apr 11, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 10, 2024

Previously, when a slow type was added to a file, the fast check was skipped, and all specifiers were checked. This new option, if toggled, allows you to check all specifiers anyway.

We should add a test, but I'm not sure how to.

Towards fixing denoland/deno#23023

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. This is kind of hard to test, but we can add a test in the CLI for it.

@dsherret dsherret changed the title feat: follow_fast_check_modules option to walk all specifiers feat: follow_fast_check_modules option for conditional walking of fast check modules Apr 11, 2024
@dsherret dsherret merged commit 88a1147 into denoland:main Apr 11, 2024
4 checks passed
@iuioiua iuioiua deleted the follow_fast_check_modules branch April 11, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants