feat(unstable): add @ts-types and clean up @deno-types #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Apr 16, 2024
lucacasonato
force-pushed
the
clean_up_deno_types_in_dependency_descriptor
branch
2 times, most recently
from
7c20979
to
0b31790
Compare
lucacasonato
changed the title
dsherret
reviewed
Apr 24, 2024
dsherret
changed the title
dsherret
reviewed
Apr 24, 2024
This allows a `@ts-types` pragma to be used instead of the `@deno-types` pragma. The `@ts-types` pragma does not allow unquoted specifiers. This also removes the `leadingComment` field in the `DependencyDescriptor` struct in favor of a `typesSpecifier` field. This requires bumping the `ModuleInfo` version to 2.
lucacasonato
force-pushed
the
clean_up_deno_types_in_dependency_descriptor
branch
from
0b31790
to
8aed3b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
@ts-typespragma to be usedinstead of the
@deno-typespragma. The@ts-typespragma does not allow unquotedspecifiers.
This also removes the
leadingCommentfield inthe
DependencyDescriptorstruct in favor of atypesSpecifierfield. This requires bumping theModuleInfoversion to 2.