Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove signIn(), handleCallback(), getSessionId(), and signOut() #322

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 26, 2024

No description provided.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.66%. Comparing base (39c46b2) to head (bb8abac).

Files Patch % Lines
lib/create_helpers.ts 96.80% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   67.79%   66.66%   -1.14%     
==========================================
  Files          37       33       -4     
  Lines        1177     1137      -40     
  Branches       72       70       -2     
==========================================
- Hits          798      758      -40     
  Misses        376      376              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit e1a5616 into main Apr 27, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-standalone-fns branch April 27, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants