-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added deprecated field to the related structs #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the added test is failing?
I tried to update the visitors as mentioned to return Ok(v), but an error shows e.g. "mismatched types MORE IMPORTANTLY, I also tried to handle the deserialization at Any insights?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is compulsory as a first step to address issue deno repo issue
Changes
Added deprecated field to related structs in order to delegate deprecation info if found back to deno.