fix(encoding/ascii85): fix encode() returns a wrong result with a 4-byte subarray
#3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Apr 10, 2023
encoding/ascii85.ts
Outdated
| @@ -65,6 +65,8 @@ const Z85 = | |||
| * @param [options.delimiter] whether to use a delimiter, if supported by encoding standard | |||
| */ | |||
| export function encode(uint8: Uint8Array, options?: Ascii85Options): string { | |||
| // Create a new Uint8Array from the given uint8 instead of using it | |||
| uint8 = new Uint8Array(uint8); | |||
There was a problem hiding this comment.
Can you try to fix the line const view = new DataView(uint8.buffer); instead of creating new uint8 array here. This causes unnecessary copy of underlying ArrayBuffer, and makes the function slower.
I think that line should be something like new DataView(uint8.buffer, uint8.byteOffset, uint8.byteLength).
There was a problem hiding this comment.
Thanks for your suggestion!
|
The test case looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3223