test(yaml): test handling of omap #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
==========================================
+ Coverage 92.26% 92.35% +0.09%
==========================================
Files 487 487
Lines 41535 41531 -4
Branches 5394 5405 +11
==========================================
+ Hits 38324 38358 +34
+ Misses 3154 3117 -37
+ Partials 57 56 -1 ☔ View full report in Codecov by Sentry. |
iuioiua
requested changes
May 24, 2024
yaml/_type/omap.ts
Outdated
Comment on lines
38
to
40
| function constructYamlOmap(data: Any): Any { | ||
| return data !== null ? data : []; | ||
| return data; | ||
| } |
There was a problem hiding this comment.
This function seems to do nothing. Can we remove it?
yaml/parse_test.ts
Outdated
|
|
||
| // Invalid omap | ||
| // map entry is not an object | ||
| assertThrows(() => parse("--- !!omap\n")); |
There was a problem hiding this comment.
Can you please add the error class and message arguments for assertThrows()? Ditto for the other instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases of
yaml, which exercises the handlingomaptype in yaml string.(
yaml/_type/omap.tsis covered 100% with this change)related: #3713